Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SM snapshots for dark mode #5052

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Add SM snapshots for dark mode #5052

merged 2 commits into from
Oct 19, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 18, 2024

Fixes

Related to #4305 by @zackkrida

Description

This PR adds snapshots for SM breakpoint.

Testing Instructions

There should only be dark snapshots added (and the change in breakpoints.ts file).
The CI should pass.
If there are any problems with the UI, the problems should be noted but not fixed in this PR.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 18, 2024
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 18, 2024
@obulat obulat self-assigned this Oct 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.9 GB  8.2 MB/s
     data_sent......................: 1.0 MB  4.6 kB/s
     http_req_blocked...............: avg=22.93µs  min=1.9µs   med=3.89µs   max=11.16ms p(90)=5.34µs  p(95)=5.76µs 
     http_req_connecting............: avg=18.69µs  min=0s      med=0s       max=11.1ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=586.65ms min=37.45ms med=528.71ms max=2.5s    p(90)=1.09s   p(95)=1.2s   
       { expected_response:true }...: avg=586.65ms min=37.45ms med=528.71ms max=2.5s    p(90)=1.09s   p(95)=1.2s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=155.38µs min=42.46µs med=116.24µs max=20.87ms p(90)=184.1µs p(95)=226.3µs
     http_req_sending...............: avg=20.28µs  min=6.25µs  med=19.35µs  max=1.01ms  p(90)=25.16µs p(95)=27.34µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=586.47ms min=37.27ms med=528.56ms max=2.5s    p(90)=1.09s   p(95)=1.2s   
     http_reqs......................: 8000    35.179543/s
     iteration_duration.............: avg=3.91s    min=1.14s   med=3.33s    max=12.48s  p(90)=8.42s   p(95)=9.06s  
     iterations.....................: 1200    5.276931/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

@obulat obulat marked this pull request as ready for review October 18, 2024 19:30
@obulat obulat requested a review from a team as a code owner October 18, 2024 19:30
@obulat obulat requested review from krysal and dhruvkb October 18, 2024 19:30
krysal
krysal approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As these snapshots accumulate, and since images take a lot of space, it's becoming more pertinent to find a way to move them to another repo so that a brand new copy of the repo doesn't take too many network resources and time to download.

...visual-regression/v-media-reuse.spec.ts-snapshots/media-reuse-rich-tab-rtl-sm-dark-linux.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing actionable, just a side comment: I wonder how readable this capture is. It looks a bit small/thin to notice all the details of the characters 😅

@obulat obulat merged commit c0ead60 into main Oct 19, 2024
53 checks passed
@obulat obulat deleted the add/dark-mode-snapshots-sm branch October 19, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krysal krysal krysal approved these changes

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Status: 🤝 Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @krysal @openverse-bot